Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2, 1.3
    • Component/s: Build System
    • Labels:
      None

      Description

      Would it be possible to set both libraries to SKIP_INSTALL=YES? Otherwise I can't build an .ipa with an app that employs the subproject.

        Activity

        Hide
        Landon Fuller added a comment -

        Can you expand a bit on the failure mode you're seeing?

        Show
        Landon Fuller added a comment - Can you expand a bit on the failure mode you're seeing?
        Hide
        Lauer, Teuber GbR added a comment -

        Sure: Both libraries install to /usr/lib (or /usr/local/lib, I don't recall which exactly). This prevents creating an .ipa, since these are not allowed to contain files beyond the application sandbox. If you set SKIP_INSTALL=yes, then on 'build and archive', a proper .ipa is being created.

        Show
        Lauer, Teuber GbR added a comment - Sure: Both libraries install to /usr/lib (or /usr/local/lib, I don't recall which exactly). This prevents creating an .ipa, since these are not allowed to contain files beyond the application sandbox. If you set SKIP_INSTALL=yes, then on 'build and archive', a proper .ipa is being created.
        Hide
        Landon Fuller added a comment -

        When Xcode performs build+archive, it actually installs any targets for which SKIP_INSTALL=no in their defined INSTALL_PATH:

        • The static libraries are installed in DESTROOT/usr/local/lib
        • The Mac OS X framework triggers an Xcode warning, as it has an INSTALL_PATH of @rpath
        • plcrashutil is installed in /usr/local/bin
        • etc.

        This results in these libraries being incorrectly included in the output of Build + Archive if PLCrashReporter is used as a nested project dependency.

        To resolve the issue, we'll set SKIP_INSTALL=yes on all library targets; all are meant to be used as embedded frameworks or static libraries, and as such, they shouldn't ever be installed in a common DESTROOT (and in the case of the Mac OS X frameworks, attempting to copy them to "@rpath" is an error).

        The framework/library targets we'll modify are:

        • CrashReporter-MacOSX
        • CrashReporter-MacOSX-Static
        • CrashReporter-iOS
        • CrashReporter-iOS-Device
        • CrashReporter-iOS-Simulator
        Show
        Landon Fuller added a comment - When Xcode performs build+archive, it actually installs any targets for which SKIP_INSTALL=no in their defined INSTALL_PATH: The static libraries are installed in DESTROOT/usr/local/lib The Mac OS X framework triggers an Xcode warning, as it has an INSTALL_PATH of @rpath plcrashutil is installed in /usr/local/bin etc. This results in these libraries being incorrectly included in the output of Build + Archive if PLCrashReporter is used as a nested project dependency. To resolve the issue, we'll set SKIP_INSTALL=yes on all library targets; all are meant to be used as embedded frameworks or static libraries, and as such, they shouldn't ever be installed in a common DESTROOT (and in the case of the Mac OS X frameworks, attempting to copy them to "@rpath" is an error). The framework/library targets we'll modify are: CrashReporter-MacOSX CrashReporter-MacOSX-Static CrashReporter-iOS CrashReporter-iOS-Device CrashReporter-iOS-Simulator
        Hide
        Landon Fuller added a comment -

        This fix was committed in 9be8a58ae375fdae8acf5f4a50cbe745b0ca85ff, and merged to master and release/plcrashreporter-1.2.

        The change will ship in PLCrashReporter 1.2.1 and later.

        Show
        Landon Fuller added a comment - This fix was committed in 9be8a58ae375fdae8acf5f4a50cbe745b0ca85ff, and merged to master and release/plcrashreporter-1.2. The change will ship in PLCrashReporter 1.2.1 and later.

          People

          • Assignee:
            Landon Fuller
            Reporter:
            Lauer, Teuber GbR
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: