Uploaded image for project: 'PLCrashReporter'
  1. PLCrashReporter
  2. PLCR-529

64KB limit on crash reports is too small

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2, 1.3
    • Component/s: Crash Log Writer
    • Labels:
      None

      Description

      "64KB should be enough for anybody" turned out to not be true in a bit of a pathological case

      /** @internal
       * Maximum number of bytes that will be written to the crash report.
       * Used as a safety measure in case of implementation malfunction.
       *
       * We provide for a generous 64k here. Most crash reports
       * are approximately 7k.
       */
      #define MAX_REPORT_BYTES (64 * 1024)
      

      Based on Joseph's testing with said case, we'll bump this to 256KB.

        Activity

        Hide
        Joe Ranieri [X] (Inactive) added a comment -

        I've easily hit 97KB on a single crash report, so the currently limit of 64KB is too small. Here's the a test crash that would have been truncated and unusable without bumping the limit.

        Show
        Joe Ranieri [X] (Inactive) added a comment - I've easily hit 97KB on a single crash report, so the currently limit of 64KB is too small. Here's the a test crash that would have been truncated and unusable without bumping the limit.
        Hide
        Landon Fuller added a comment -

        This has been committed to 1.2 and merged to master. We'll be deploying a new (and hopefully final) 1.2 release candidate containing this fix.

        Show
        Landon Fuller added a comment - This has been committed to 1.2 and merged to master. We'll be deploying a new (and hopefully final) 1.2 release candidate containing this fix.

          People

          • Assignee:
            Landon Fuller
            Reporter:
            Joe Ranieri [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: