Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: Thread State
-
Labels:None
-
Only Affects (Apple):iOS
Description
Our ARM assembly functions are aligned using the following construct:
#if __arm__
.align 2
#endif
__arm__ is only defined for 32-bit ARM targets, and this failed silently on Xcode 5.0.
In Xcode 5.1, ld now (thankfully) emits a warning on unaligned functions:
Arm64 function not 4-byte aligned: _plcrash_async_thread_state_current from ...
PC addresses must be 4 byte aligned (see also: ARMv8 Architecture Reference Manual). We need to fix our alignment #if guards to correctly align the ARM64 functions, which will queisce this linker warning.
Issue Links
- blocks
-
PLCR-541 Fix all linker warnings
-
- Open
-
Resolved and merged to release/plcrashreporter-1.2 and master.