Uploaded image for project: 'PLCrashReporter'
  1. PLCrashReporter
  2. PLCR-542

Fix AArch64 Alignment Issues

          Details

          • Type: Bug Bug
          • Status: Resolved
          • Priority: Blocker Blocker
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.2, 1.3
          • Component/s: Thread State
          • Labels:
            None
          • Only Affects (Apple):
            iOS

            Description

            Our ARM assembly functions are aligned using the following construct:

            #if __arm__
.align 2
#endif

            __arm__ is only defined for 32-bit ARM targets, and this failed silently on Xcode 5.0.

            In Xcode 5.1, ld now (thankfully) emits a warning on unaligned functions:

            Arm64 function not 4-byte aligned: _plcrash_async_thread_state_current from ...

            PC addresses must be 4 byte aligned (see also: ARMv8 Architecture Reference Manual). We need to fix our alignment #if guards to correctly align the ARM64 functions, which will queisce this linker warning.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. PLCR-541 Fix all linker warnings

              • Major - Major loss of function.
              • Open

                Activity

                Hide
                Permalink
                Landon Fuller added a comment -

                Resolved and merged to release/plcrashreporter-1.2 and master.

                Show
                Landon Fuller added a comment - Resolved and merged to release/plcrashreporter-1.2 and master.

                  People

                  • Assignee:
                    Landon Fuller
                    Reporter:
                    Landon Fuller
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: